build: include private exports in fesms #23054
Conversation
|
You can preview c809b1b at https://pr23054-c809b1b.ngbuilds.io/. |
alexeagle
force-pushed
the
fesm_fix
branch
2 times, most recently
from
d8b0c83
to
5cfc94f
Compare
|
You can preview d8b0c83 at https://pr23054-d8b0c83.ngbuilds.io/. |
|
You can preview 5cfc94f at https://pr23054-5cfc94f.ngbuilds.io/. |
alexeagle
force-pushed
the
fesm_fix
branch
2 times, most recently
from
5b33f28
to
0b6e615
Compare
|
You can preview 5b33f28 at https://pr23054-5b33f28.ngbuilds.io/. |
|
You can preview 0b6e615 at https://pr23054-0b6e615.ngbuilds.io/. |
| # We do this just when producing a flat module index for a publishable ng_module | ||
| if _should_produce_flat_module_outs(ctx): | ||
| flat_module_out = _flat_module_out_file(ctx) | ||
| devmode_js_files.append(ctx.actions.declare_file("%s.js" % flat_module_out)) |
There was a problem hiding this comment.
maybe it's me being spoiled by javascript but I find this "backwards/printf" interpolation style less readable than using +.
it would be cool if skylark added support for f-string interpolation (f'Hello {name}! This is {program}') https://www.programiz.com/python-programming/string-interpolation.
Can we put that on our bazel wishlist?
There was a problem hiding this comment.
file a feature request? I'm only tracking things that will block adoption.
| for dep in deps_in_package: | ||
| # Intentionally evaluates to empty string for the main entry point | ||
| entry_point = dep.label.package[len(ctx.label.package) + 1:] | ||
| if hasattr(dep, "angular") and dep.angular.flat_module_metadata: |
There was a problem hiding this comment.
this fails with
"/home/travis/.cache/bazel/_bazel_travis/45f6fb64fc863da959d1d83d36b18214/external/angular/src/ng_package/ng_package.bzl", line 130, in _ng_package_impl
dep.angular.flat_module_metadata
'struct' object has no attribute 'flat_module_metadata'
Available attributes: summaries
IgorMinar
force-pushed
the
fesm_fix
branch
2 times, most recently
from
5d6324c
to
41c3f9f
Compare
|
You can preview 5d6324c at https://pr23054-5d6324c.ngbuilds.io/. |
|
You can preview 41c3f9f at https://pr23054-41c3f9f.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information